ConstProp: stop pooling inline constants #4036
Merged
+19
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssarosenzweig
force-pushed
the
opt/dont-inline-pool
branch
from
ec3723e to
e81a9aa
Compare
Because we already pooled the _Constants, there's no benefit to also pooling inline constants. the robin map to do so just adds extra overhead for no benefit - drop it. without multiblock, shaves around 2% off node. with multiblock, a bit less than 1% but still a win. Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
opt/dont-inline-pool
branch
from
e81a9aa to
d1d4d2d
Compare
bit of cleanup Signed-off-by: Alyssa Rosenzweig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
despite conventional wisdom, the robin map is slower than emitting extra nodes.
without multiblock, shaves around 2% off node. with multiblock, a bit less than 1% but still a win.